Merge | Move ReliabilitySection / BestEffortCleanup to framework specific files #2984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2984 +/- ##
==========================================
+ Coverage 72.64% 72.67% +0.02%
==========================================
Files 285 286 +1
Lines 59160 59160
==========================================
+ Hits 42979 42995 +16
+ Misses 16181 16165 -16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
MichelZ
force-pushed
the
tdsparser-move-netcorenetfxcode
branch
from
c634c01 to
ac8aa33
Compare
benrr101
approved these changes
Nov 14, 2024
benrr101
added
the
Common Project 🚮
cheenamalhotra
approved these changes
Nov 15, 2024
|
@MichelZ if you can resolve the conflict, I can get this merged 🚢 |
|
@benrr101 Done! Thx |
MichelZ
changed the title
This was referenced Jul 25, 2025
Open
This was referenced Oct 13, 2025
This was referenced Oct 20, 2025
This was referenced Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think we want to wrap those in #IF NETFRAMEWORK / NETCORE conditional compiles, it makes sense to have them in their own files, so I've moved them out of the "future-common-project" file(s)
Part of #2953